Fix old unique jobs digests not having been cleaned up #13683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
approved these changes
May 9, 2020
|
Shouldn't this be a post-deployment migration? |
|
It will probably not be possible for problematic locks to be created in the time it takes to upgrade. I can see your point and ideally I guess it should've been a post-deployment migration but since the actual fix was already released before, most people upgrading will have been running fixed code before this migration anyway. Hm. |
|
Hm… we could still merge it, would avoid potential issues for people “skipping releases” (which I don't think should be discouraged—apart from the fact that not updating should be discouraged I mean—and is sometimes required since some releases can't be installed anymore, and that may happen to more releases down the road). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.