Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single option votes tooltip in polls #16849

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add single option votes tooltip in polls #16849

merged 1 commit into from
Oct 13, 2021

Conversation

brawaru
Copy link
Contributor

@brawaru brawaru commented Oct 12, 2021

Adds a tooltip when hovering over the percentages in a poll showing how many votes were cast for that option.

Fixes #16820

Screenshot showing cursor being hovered over the percentage in a poll, displaying ‘474 votes’

voted: {
id: 'poll.voted',
defaultMessage: 'You voted for this answer',
description: 'Tooltip of the "voted" checkmark in polls',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked I think this field did not get picked up by Crowdin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well! I'll remove it and other descriptions as well then so they don't confuse anyone else 😅

Adds a tooltip when hovering over the percentages in a poll showing how
many votes were cast for that option.

Also removes descriptions from messages here since they are not picked
up by Crowdin anyway and might be confusing to other developers :)

Fixes #16820
@Gargron Gargron merged commit 89b5071 into mastodon:main Oct 13, 2021
@brawaru brawaru deleted the feat/poll-votes-count-1 branch October 13, 2021 07:31
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this pull request Feb 10, 2022
Adds a tooltip when hovering over the percentages in a poll showing how
many votes were cast for that option.

Also removes descriptions from messages here since they are not picked
up by Crowdin anyway and might be confusing to other developers :)

Fixes mastodon#16820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show absolute numbers for poll results
3 participants