Remove useless reorder(nil) call in tootctl statuses
#28141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renchap
added
refactoring
mjankowski
force-pushed
the
cli-scope-statuses-media-attachment
branch
from
4118248
to
159a35f
Compare
Eh - for me most of the benefit (marginal, I would agree!) is in getting rid of the local var. Updated to be just a removal of the unneeded |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28141 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 1038 1038
Lines 28220 28220
Branches 4550 4550
=======================================
Hits 23475 23475
Misses 3635 3635
Partials 1110 1110 ☔ View full report in Codecov by Sentry. |
ClearlyClaire
approved these changes
Dec 7, 2023
ClearlyClaire
changed the title
aged_media_attachments helper method to statuses CLIreorder(nil) call in tootctl statuses
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Dec 14, 2023
vmstan
pushed a commit
to vmstan/mastodon
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a well named private method instead of the
scopelocal variable, and removes areorderthat I must have missed in the recent MediaAttachment default_scope PR.