Change behavior of privacy dropdown to only change value on validation #29406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
added
ui
ClearlyClaire
force-pushed
the
fixes/privacy-dropdown-behavior
branch
from
603c673 to
fd99d09
Compare
renchap
approved these changes
Feb 27, 2024
Ember-ruby
pushed a commit
to Ember-ruby/mastodon-glitch
that referenced
this pull request
Mar 19, 2024
lutoma
pushed a commit
to ohaisocial/mastodon
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the post privacy settings to only update when clicking or pressing “Enter” or “space” on an option, as opposed to changing on keyboard validation (tab/up/down/home/end when the menu is open).
This allows exploring options without mistakenly selecting them, avoids the UI changing below the menu (addition of warnings) while navigating it, and provides consistency with the language picker menu.
Additionally, I noticed that neither of these menus handled the “space” key as validating the selection, and fixed that.
Finally, I took the opportunity to split the dropdown menu component to its own file and rewrite it as a functional component (which will also allow reuse of code in a fork I maintain).