Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance: Use event.ParsePayload() instead of deprecated event.Payload() #111

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

MH4GF
Copy link
Contributor

@MH4GF MH4GF commented Oct 19, 2023

event.Payload() は非推奨になっていたため、代替先の event.ParsePayload() に切り替えました。

ref: https://pkg.go.dev/github.com/google/go-github@v17.0.0+incompatible/github#Event.Payload

動作確認

  • make dist でビルドしたパッケージを実行し( ./pkg/darwin_arm64/github-nippou )、変わらず動作することを確認しています。
  • 手元で make test-all が通ることを確認しています。

@MH4GF MH4GF marked this pull request as ready for review October 19, 2023 01:06
Copy link
Owner

@masutaka masutaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます! 非推奨に気づきませんでした 😅

@masutaka masutaka merged commit 7b116d2 into masutaka:master Oct 19, 2023
@masutaka
Copy link
Owner

🚀 v4.2.4

@MH4GF MH4GF deleted the fix-depracated-api branch October 19, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants