Enable to inject settings_gist_id instead of the settings #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masutaka
commented
Aug 6, 2017
| @@ -2,18 +2,14 @@ | |||
| let(:client) { Octokit::Client.new(login: 'taro', access_token: '1234abcd') } | |||
| let(:settings) { described_class.new(client: client) } | |||
|
|
|||
| before do | |||
| ENV['GITHUB_NIPPOU_SETTINGS_GIST_ID'] = '12345' | |||
| allow(client).to receive(:gist).and_return( files: { 'settings.yml': { content: settings_yaml } } ) | |||
There was a problem hiding this comment.
WebMock gem だとどうしてもうまくいかなかったので、この辺で妥協しておく。
WebMock.stub_request に JSON（つまり String）を渡すと、Octokit::Client#gist が Hash ライクなオブジェクト（Sawyer::Resource）ではなく、JSON を返してしまう。
WebMock::Response::InvalidBody: must be one of: [Proc, IO, Pathname, String, Array]. 'Hash' given
ならばと Hash を渡すと上記のエラーに遭遇。
| config.include LoadFixtureHelper | ||
|
|
||
| config.before(:all) { silence_stdout } | ||
| config.after(:all){ enable_stdout } |
There was a problem hiding this comment.
Github::Nippou::Settings#data で puts しており、rspec の結果が Noisy になるため。YAML syntax error は発生しやすいと思うので、親切に教えてあげたい。
There was a problem hiding this comment.
いわゆる printf デバッグできないのでリバートしました...。→ 7a75ef5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #59
$GITHUB_NIPPOU_SETTINGS_GIST_IDgithub-nippou.settingsin ~/.gitconfig and$GITHUB_NIPPOU_SETTINGS#58 (comment) の辺りで話した件。
Dockerize も見据えると、Gist ID を環境変数で Inject 出来たほうが都合が良い（~/.gitconfig の
github-nippou.settings-gist-idはすでに Inject 出来ていた）。