fix(Ast): Fix angulardart#1502, bad recovery.

matanlurey · Aug 17, 2018 · 40e467d · 40e467d
1 parent 5c9d83e
commit 40e467d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/angular_ast/lib/src/visitors/desugar_visitor.dart b/angular_ast/lib/src/visitors/desugar_visitor.dart
@@ -196,7 +196,11 @@ class DesugarVisitor implements TemplateAstVisitor<TemplateAst, String> {
         );
       } catch (e) {
         exceptionHandler.handle(e);
-        return astNode;
+        if (astNode is EmbeddedTemplateAst) {
+          return astNode;
+        }
+        // We parsed this as something unexpected, and should not continue.
+        rethrow;
       }
       if (micro != null) {
         propertiesToAdd.addAll(micro.properties);

diff --git a/angular_ast/test/expression/micro/parser_test.dart b/angular_ast/test/expression/micro/parser_test.dart
@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:angular_ast/angular_ast.dart';
 import 'package:angular_ast/src/ast.dart';
 import 'package:angular_ast/src/expression/micro/ast.dart';
 import 'package:angular_ast/src/expression/micro/parser.dart';
@@ -124,4 +125,11 @@ void main() {
       ),
     );
   });
+
+  test('should a parser error on trailing semi-colon', () {
+    expect(
+      () => parse('ngFor', 'let item of items;', 0),
+      throwsA(TypeMatcher<AngularParserException>()),
+    );
+  });
 }