Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Display active python virtual environment #146

Closed
Pilgrim1379 opened this issue Jan 22, 2019 · 4 comments
Closed

Display active python virtual environment #146

Pilgrim1379 opened this issue Jan 22, 2019 · 4 comments
Labels
Good First Issue Good for newcomers Status: Available Type: Enhancement New feature or request

Comments

@Pilgrim1379
Copy link

How does one enable the display of the current active python virtual environment in the prompt?

@matchai
Copy link
Owner

matchai commented Jan 23, 2019

Hey @ThePreacher! Thank you for your interest in having Python virtual environments being added to spacefish.

This is definitely a feature we'd be interested in having added to the project, and we would welcome contributions if you would be interested in contributing. 😄

Here is the equivalent section file from spaceship, which implements the venv section: https://github.com/denysdovhan/spaceship-prompt/blob/master/sections/venv.zsh

@matchai matchai added Type: Enhancement New feature or request Good First Issue Good for newcomers Status: Available labels Jan 23, 2019
@azdanov
Copy link

azdanov commented Jan 25, 2019

@matchai Hey! 👋

Don't want to open another issue since these are kinda similar.

I was wondering if making pipenv work is somewhat the same?

@johnfraney
Copy link

@azdanov Both virtualenv and pipenv set the $VIRTUAL_ENV environment variable, which is how the pure fish prompt provides this functionality.

matchai pushed a commit that referenced this issue Feb 24, 2019
This PR adds the requested features to #146
Tests and docs updated as well
matchai pushed a commit that referenced this issue Feb 24, 2019
# [2.3.0](v2.2.4...v2.3.0) (2019-02-24)

### Features

* add Python venv section ([#164](#164)) ([3d777fc](3d777fc)), closes [#146](#146)
@matchai
Copy link
Owner

matchai commented Mar 1, 2019

Whoops! Forgot to close this one. 😅

@matchai matchai closed this as completed Mar 1, 2019
adamsimp pushed a commit to adamsimp/spacefish that referenced this issue May 6, 2019
This PR adds the requested features to matchai#146
Tests and docs updated as well
adamsimp pushed a commit to adamsimp/spacefish that referenced this issue May 6, 2019
# [2.3.0](matchai/spacefish@v2.2.4...v2.3.0) (2019-02-24)

### Features

* add Python venv section ([matchai#164](matchai#164)) ([3d777fc](matchai@3d777fc)), closes [matchai#146](matchai#146)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue Good for newcomers Status: Available Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants