-
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kulabun! 👋
Glad to see another contribution from you!
This PR is looking great! I just have a few quick comments before we can get it merged in. 😁
Hey @matchai , |
Wow, that's interesting. After my commit CI start failing with this:
Unfortunately right after running fish_vi_key_bindings CI have fish_bind_mode in 'normal' state instead of 'insert'. Fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
Thank you for the contribution @kulabun!
Vi-mode Feature Implementation
Description
Implements Vi-Mode Feature. There are some difference with zsh's spaceship implementation:
Also I have overridden default fish_mode_prompt to avoid duplication. I think it better to have it all out of box.
Motivation and Context
#74
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: