Add support for chruby #46
Conversation
|
For reference, this is where |
functions/__sf_section_ruby.fish
Outdated
| @@ -12,7 +12,7 @@ function __sf_section_ruby -d "Show current version of Ruby" | |||
| __sf_util_set_default SPACEFISH_RUBY_SHOW true | |||
| __sf_util_set_default SPACEFISH_RUBY_PREFIX $SPACEFISH_PROMPT_DEFAULT_PREFIX | |||
| __sf_util_set_default SPACEFISH_RUBY_SUFFIX $SPACEFISH_PROMPT_DEFAULT_SUFFIX | |||
| __sf_util_set_default SPACEFISH_RUBY_SYMBOL "💎 " | |||
| __sf_util_set_default SPACEFISH_RUBY_SYMBOL "💎 " | |||
There was a problem hiding this comment.
Is there a reason this extra space was added?
There was a problem hiding this comment.
Sure, maybe it's just my font, but this looked super weird with a monospace font. I'm fine removing this, just thought it looked better. Here's what it looks like without the space:
There was a problem hiding this comment.
Yep I agree! However spacefish's philosophy is to follow spaceship's standards as much as possible. So it would be up to the individual user to decide if they want to change the default one space.
There was a problem hiding this comment.
Oh man I totally misunderstood what was going on, sounds great! I'll remove this.
There was a problem hiding this comment.
If you're encountering this in iTerm, take a look at this part of the FAQ: https://github.com/matchai/spacefish/blob/master/docs/Troubleshooting.md#why-do-my-section-icons-overlap-each-other
There was a problem hiding this comment.
This is great, thanks @matchai !
There was a problem hiding this comment.
Turns out I actually can't use this setting @matchai :( I'm using powerline fonts and it messes with those characters
functions/__sf_section_ruby.fish
Outdated
| @@ -29,6 +29,8 @@ function __sf_section_ruby -d "Show current version of Ruby" | |||
| set ruby_version (rvm-prompt i v g) | |||
| else if type -q rbenv | |||
| set ruby_version (rbenv version-name) | |||
| else if type -q chruby | |||
| set ruby_version (echo $RUBY_AUTO_VERSION) | |||
There was a problem hiding this comment.
Looks like the indentation for these added lines is off, we use tabs, equivalent to 4 spaces I believe.
There was a problem hiding this comment.
Oh man I totally missed this! My bad, I'll swap these to tabs
There was a problem hiding this comment.
Haha yeah just noticed that. Removed in the latest commit
functions/__sf_section_ruby.fish
Outdated
| @@ -29,6 +29,8 @@ function __sf_section_ruby -d "Show current version of Ruby" | |||
| set ruby_version (rvm-prompt i v g) | |||
| else if type -q rbenv | |||
| set ruby_version (rbenv version-name) | |||
| else if type -q chruby | |||
| set ruby_version (echo $RUBY_AUTO_VERSION) | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thank you for the contribution @kyleholzinger! |
|
Of course @matchai ! |
Description
This adds support for chruby in the ruby version section
Motivation and Context
Helps close #35
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: