This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Add section tests for node #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matchai
changed the title
matchai
commented
Jul 25, 2018
| @@ -13,7 +13,7 @@ function __sf_section_node -d "Display the local node version" | |||
| __sf_util_set_default SPACEFISH_NODE_PREFIX $SPACEFISH_PROMPT_DEFAULT_PREFIX | |||
| __sf_util_set_default SPACEFISH_NODE_SUFFIX $SPACEFISH_PROMPT_DEFAULT_SUFFIX | |||
| __sf_util_set_default SPACEFISH_NODE_SYMBOL "⬢ " | |||
| __sf_util_set_default SPACEFISH_NODE_DEFAULT_VERSION $SPACEFISH_NODE_DEFAULT_VERSION | |||
| __sf_util_set_default SPACEFISH_NODE_DEFAULT_VERSION "" | |||
There was a problem hiding this comment.
Should default to empty string. Not sure why it was defaulting to itself before. 😅
matchai
commented
Jul 25, 2018
| @@ -73,7 +73,7 @@ function __sf_section_battery -d "Displays battery symbol and charge" | |||
| end | |||
|
|
|||
| # Remove trailing % and symbols for comparison | |||
| set battery_percent (echo $battery_percent | tr -d "%[,;]") | |||
| set battery_percent (echo $battery_percent | string trim --chars=%[,;]) | |||
There was a problem hiding this comment.
Use fish string manipulation utils to ensure compatibility with Unix emulators that may not have tr. 🐟
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mock.fishto allow for the mocking of utilitiesMotivation and Context
Increases our test coverage!
Types of changes
How Has This Been Tested?
Checklist: