This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Added changes from Spaceship upstream! 🚀⭐ #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a config option to enable/disable verbose versioning, which should be disabled by default. Upstream pull request: spaceship-prompt/spaceship-prompt#521
matchai
reviewed
Oct 5, 2018
functions/__sf_section_rust.fish
Outdated
| @@ -32,6 +33,10 @@ function __sf_section_rust -d "Display the current Rust version" | |||
|
|
|||
| set -l rust_version (rustc --version | cut -d' ' -f2) | |||
There was a problem hiding this comment.
Thinking it over, I think the "fish way" of doing this would be.
set -l rust_version (rustc --version | string split ' ')[2]It's effectively the same, but would be more approachable for those familiar with fish commands. Thoughts? 🤔
matchai
reviewed
Oct 5, 2018
|
OH! I totally forgot that fish already has a way to do this. Great thinking, @matchai! |
This replaces the cut command with Fish's "string" builtin. If you have fish installed, view "file:///usr/share/doc/fish/commands.html#string" in your browser of choice. Co-authored-by: Matan Kushner <hello@matchai.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a config option to enable/disable verbose versioning,
which should be disabled by default.
Upstream pull request:
spaceship-prompt/spaceship-prompt#521
Motivation and Context
The original rust section displays the verbose version by default. For example:
v1.30.0-nightly,v1.30.0-betaorv1.30.0, depending on what branch you were using. (Stable not having a suffix)This change makes non-verbose version numbers the default
v1.30.0, and a config option to enable it only if wanted.Types of changes
(All three)
How Has This Been Tested?
I have tested using the
./tests/run.fishlocally, as well as running logical snippets in my shell to make sure the syntax is correct.Checklist: