Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delivering just like Pat&Mat ;) #60

Closed
wants to merge 266 commits into from
Closed

Delivering just like Pat&Mat ;) #60

wants to merge 266 commits into from

Conversation

jmederosalvarado
Copy link

No description provided.

jmederosalvarado and others added 30 commits March 2, 2021 15:24
@jmederosalvarado
Parser builds ast
9ebdd98
@jmederosalvarado
Add utils module
1899f11
@jmederosalvarado
Add semantic module
965e45d
@jmederosalvarado
Remove parser debug flag
43ef7d4
@jmederosalvarado
Change ast structure
80a67a6
@jmederosalvarado
Add visitors module
2f88884
@jmederosalvarado
Add todo in semantic
9060fb4
@jmederosalvarado
Just commit
7aa5e43
@jmederosalvarado
Add type collection
ed03295
@jmederosalvarado
Add type collection stage
7995b5c
@jmederosalvarado
Update visitor
8d151eb
@jmederosalvarado
Change way of mapping ast hierarchies
edbe012
@jmederosalvarado
Change meta way
a663c25
@jmederosalvarado
Add type builder
44dda41
@jmederosalvarado
Changes map_to_module
f06b65d
@jmederosalvarado
FIx some stuff
2d34144
@jmederosalvarado
Upload to share
f3a44b0
@jmederosalvarado
Big commit
ca3ada2
fix some errors
c57c7b1 
lexer and parser working fine
@jmederosalvarado
Add style rule to makefile
230460d
fix some bugs
94cbdbc
Merge branch 'master' of https://github.com/pat-and-mat/cool-compiler…
0ce0fbe 
…-2021
@jmederosalvarado
Format
7076695
small self changes
32c0412
@jmederosalvarado
Fix DispatchNode constructor error
57a97e9
Merge branch 'master' of https://github.com/pat-and-mat/cool-compiler…
42eb92b 
…-2021
@jmederosalvarado
Remove context references
acd08bb
delete useless print
bf7b920
Merge branch 'master' of https://github.com/pat-and-mat/cool-compiler…
0ebe5c6 
…-2021
fix atom values
cf32294
@apiad
Copy link
Member

apiad commented Mar 8, 2022 •
edited by jpconsuegra
Loading

Evaluación

  • Jorge Mederos Alvarado
  • Rodrigo García Gómez

Requisitos mínimos (3)

  • El proyecto pasa todos los tests
  • El informe existe y explica el uso del compilador y la arquitectura básica

Requisitos intermedios (4)

  • Se implementaron las fases de chequeo semántico de forma separada y utilizando patrones adecuados
  • La arquitectura del compilador está organizada de forma coherente y mantenible

Requisitos extra (5)

  • Se implementaron las fases de generación de código intermedio y código objeto con patrones adecuados
  • Se resolvieron los problemas de representación de objetos en memoria e invocación de métodos virtuales de forma eficiente
  • Se resolvieron los problemas de boxing/unboxing de forma eficiente
  • Se resuelve el case de forma eficiente

Comentarios

  • No encontré el informe ¡! SOLVED
  • No explica como resuelve los comentarios anidados.
  • Resuelven el case generando todos los descendientes.
  • Siempre hacen boxing. SOLVED
  • AST Inmutables (:+1: )

Nota final

Evaluación Nota
Final 2
Extraordinario 5

@apiad apiad self-requested a review March 8, 2022 02:35
Rodrigo added 4 commits March 9, 2022 03:21
@jpconsuegra
Copy link
Contributor

Revisado

@jpconsuegra jpconsuegra self-assigned this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apiad apiad Awaiting requested review from apiad

Assignees

@jpconsuegra jpconsuegra

Labels
Aprobado Extra Finalizado Suspenso Final
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmederosalvarado @apiad @jpconsuegra