Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use .Site.BaseURL for assets #25

Closed
ripienaar opened this issue Dec 18, 2016 · 2 comments
Closed

use .Site.BaseURL for assets #25

ripienaar opened this issue Dec 18, 2016 · 2 comments

Comments

@ripienaar
Copy link
Contributor

all assets have hardcoded paths like /css should be baseurl related

@matcornic
Copy link
Owner

Thanks @ripienaar for your PR :)

Actually, you're not the first to create this specific one. See #6 & #9 & #3

Instead of putting baseurls, you could use the obscure Hugo parameter named canonifyURLs = true (as I did in the documentation : https://github.com/matcornic/hugo-learn-doc/blob/master/config.toml#L6 )

But as your are not the first to share this (and I think you won't be the last if this does not change), I will accept your PR. It will be more obvious and straightforward for everybody (cc @nimmaj @fanningert @TimNN)

matcornic added a commit that referenced this issue Dec 19, 2016
@ripienaar
Copy link
Contributor Author

oh thats what canonifyURLs does :) docs really not clear, I saw other themes used the baseurl that seemed a lot more obvious

thanks for the merge and the theme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants