Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select option color in Chrome #345

Merged
merged 1 commit into from
Feb 1, 2020
Merged

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Nov 15, 2019

The current nucleus.css adds color: inherit for <select>. However, in Google Chrome, this also affects the <option> elements. Thus if the parent text color is white, then the option color will be white too, making the option text invisible against its default white background.

This PR simply adds a color: initial to the general theme.css.

@matalo33 matalo33 added the bug label Feb 1, 2020
@matalo33 matalo33 added this to the v2.5.0 milestone Feb 1, 2020
@matalo33 matalo33 merged commit 15f8909 into matcornic:master Feb 1, 2020
@fritzmg fritzmg deleted the patch-4 branch February 3, 2020 10:46
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants