-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Checkmark On visited Links #4
Conversation
Many thanks @Xipas for your PR :) I did not implemented this functionality because, personally, I did not find it useful. But other people (like you 😋) do. So, can you add an optional boolean Thank you for your understanding. |
Done :) |
Added a css code to set color and align to right. |
Updated the doc as well : https://matcornic.github.io/hugo-learn-doc/basics/configuration/ |
#sidebar ul.topics > li > a .fa { | ||
margin-top: 9px; | ||
} | ||
#sidebar ul li .fa { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xipas Did not see it at the first time, but if we define an font awesome icon in the prefix of a menu item, it's not shown. We should add a class for the check icon, in order to be specific.
@Xipas I added a comment on the code of your PR. I got a regression when I used Font Awesome icons as prefix for the menu (ex in front matter of a chapter page : |
feat: add icon on menu which have children + fix attachements shortcode
Added the missing code to show the checkmark on visited links on sidebar. All js code was already in place, just missing some html.