Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Checkmark On visited Links #4

Merged
merged 4 commits into from
May 24, 2016
Merged

Add Checkmark On visited Links #4

merged 4 commits into from
May 24, 2016

Conversation

Xipas
Copy link
Contributor

@Xipas Xipas commented May 23, 2016

Added the missing code to show the checkmark on visited links on sidebar. All js code was already in place, just missing some html.

@matcornic
Copy link
Owner

Many thanks @Xipas for your PR :)

I did not implemented this functionality because, personally, I did not find it useful. But other people (like you 😋) do.

So, can you add an optional boolean showVisitedLinks parameter like this ? Then use .Site.Params.showVisitedLinks in the Go Template.

Thank you for your understanding.

@Xipas
Copy link
Contributor Author

Xipas commented May 24, 2016

Done :)

@Xipas
Copy link
Contributor Author

Xipas commented May 24, 2016

Added a css code to set color and align to right.

@matcornic matcornic merged commit 2adc47a into matcornic:master May 24, 2016
@matcornic
Copy link
Owner

#sidebar ul.topics > li > a .fa {
margin-top: 9px;
}
#sidebar ul li .fa {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xipas Did not see it at the first time, but if we define an font awesome icon in the prefix of a menu item, it's not shown. We should add a class for the check icon, in order to be specific.

@matcornic
Copy link
Owner

@Xipas I added a comment on the code of your PR. I got a regression when I used Font Awesome icons as prefix for the menu (ex in front matter of a chapter page : icon: "<i class='fa fa-users'></i>")

@matcornic
Copy link
Owner

@Xipas it's fixed in de8584e

dcrankshaw pushed a commit to dcrankshaw/hugo-theme-learn that referenced this pull request Sep 13, 2017
feat: add icon on menu which have children + fix attachements shortcode
mhenstell pushed a commit to nnja/hugo-theme-learn that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants