Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AIR task #983

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add AIR task #983

wants to merge 2 commits into from

Conversation

lishvets
Copy link

@lishvets lishvets commented Sep 6, 2024

volodymyr-soltys97
volodymyr-soltys97 suggested changes Sep 6, 2024
View reviewed changes
Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's improve your page

  1. Remove default border for this button
image
  1. Add transition for hover effects here
image
  1. Change the autofill styles for the form fields
    https://css-tricks.com/snippets/css/change-autocomplete-styles-webkit-browsers/
image
  1. Fix this error after submit form
image
  1. Add hover effects here
image
  1. Remove scroll when this menu is open
image

etojeDenys
etojeDenys approved these changes Sep 7, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to

  1. disable scroll when the menu is open
  2. disable page reloading on form submit
  3. add the smooth scroll on the anchor click

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@volodymyr-soltys97 volodymyr-soltys97 Awaiting requested review from volodymyr-soltys97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lishvets @volodymyr-soltys97 @etojeDenys