Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dia #989

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

dia #989

wants to merge 3 commits into from

Conversation

Alex-redman
Copy link

@Alex-redman Alex-redman commented Sep 19, 2024 •
edited
Loading

GUSILLUS
GUSILLUS suggested changes Sep 19, 2024
View reviewed changes
Copy link

@GUSILLUS GUSILLUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Consider fixing your demo link for future
image

etojeDenys
etojeDenys suggested changes Sep 20, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image
image
image

  1. add some hovers to all links

  2. it should be the links that start a call or open maps

image

etojeDenys
etojeDenys approved these changes Sep 20, 2024
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not open a new tab on phone click
image

  1. as you can see, all sections have the same width in the mockup
image compare to you image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etojeDenys etojeDenys etojeDenys approved these changes

@GUSILLUS GUSILLUS Awaiting requested review from GUSILLUS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alex-redman @etojeDenys @GUSILLUS