Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #996

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Develop #996

wants to merge 13 commits into from

Conversation

MOODDDII
Copy link

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your demo link doesn't work, pls fix it and the re-request the review

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
To improve:

  1. Change title on the page to Dia
image
  1. Add cursor pointer for all clickable elements
image
  1. Add hover effects for all clickable elements
image
  1. Open this additional link in the new tab
image
  1. You don't need to refresh page after submitting form, you need only reset form fields
image
  1. Add transition when this menu appears on the page and add close icon for close menu
image

Copy link

@anastasiiavorobiova anastasiiavorobiova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

  • Screenshot 2024-10-20 at 14 42 31
  • Consider fixing the layout for mobiles
  • Screenshot 2024-10-20 at 14 41 02
  • Screenshot 2024-10-20 at 14 41 09
  • Check styles here
  • Screenshot 2024-10-20 at 14 40 39
  • Consider adding hover effects here
  • Screenshot 2024-10-20 at 14 40 12
  • Screenshot 2024-10-20 at 14 40 16
  • Check styles here
  • Screenshot 2024-10-20 at 14 39 25
  • Check fonts here

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it should be the textarea
image
  1. almost done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants