Skip to content

Commit

Permalink
Merge branch 'master' into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
DmytroPAvlichenko committed Sep 11, 2024
2 parents 1b164bb + f2d4745 commit 5a3f65b
Show file tree
Hide file tree
Showing 4 changed files with 7,300 additions and 4,236 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:

strategy:
matrix:
node-version: [14.x]
node-version: [20.x]

steps:
- uses: actions/checkout@v2
Expand All @@ -23,7 +23,7 @@ jobs:
- run: npm test
- name: Upload HTML report(backstop data)
if: ${{ always() }}
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: report
path: backstop_data
10 changes: 5 additions & 5 deletions checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,9 @@
</details>

<details>
<summary>Don't use spaces in links</summary>
<summary>Don't use spaces in `<a>` tag's `href` property</summary>

> Have you seen any link with literal space in it on the Internet? Remember, anchor links start with `#`
> Anchor links starts with the `#` symbol
</details>

## CSS
Expand All @@ -194,7 +194,7 @@
<details>
<summary>Don't use tag names for styling (except <code>html</code> and <code>body</code>)</summary>

> Style all elements using `.classes` and if needed with `:pseudo-classes`, `pseudo-elements` and `[attributes]`
> Style all elements using `.class` and if needed with `:pseudo-class`, `pseudo-element` and `[attribute]`

HTML Example
```html
Expand Down Expand Up @@ -231,9 +231,9 @@
</details>

<details>
<summary>Be consistent with your margins (Add only top or bottom, but not both)</summary>
<summary>Be consistent with your *vertical* margins (Add only top or only bottom margin, but not both)</summary>

> To avoid potential margin collapse
> Vertical margins can be collapsed in some cases
</details>

<details>
Expand Down
Loading

0 comments on commit 5a3f65b

Please sign in to comment.