Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution | second pull request #5347

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kitaru64
Copy link

@kitaru64 kitaru64 commented Sep 9, 2024

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls, feel free to ask for some help in the chat to fix your demo links

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
Let's make your code better

src/index.html Outdated
Comment on lines 40 to 41
</li>
<li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the blank line between the links

Suggested change
</li>
<li>
</li>
<li>

src/style.css Outdated
margin: 0;
box-sizing: border-box;
font-family: Roboto, sans-serif;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move font family to the html selector

box-sizing: border-box;
font-family: Roboto, sans-serif;

--header-height: 60px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a variable with :root selector

src/style.css Outdated
justify-content: space-between;
align-items: center;

position: fixed;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant

Suggested change
position: fixed;

src/index.html Outdated
Comment on lines 31 to 36
<nav class="navbar">
<ul class="navbar__list">
<li>
<a
href="#"
class="navbar__link is-active"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix classes everywhere

Suggested change
<nav class="navbar">
<ul class="navbar__list">
<li>
<a
href="#"
class="navbar__link is-active"
<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="nav__link is-active"

src/style.css Outdated
margin: auto 0;
}

.navbar__list li:not(:first-child) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.navbar__list li:not(:first-child) {
.nav__item:not(:first-child) {

src/style.css Outdated
}

.navbar__link:hover {
color: #00acdc;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a variable for repeated color and use it everywhere

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I almost sure that you need to update the color of links to pass tests

Comment on lines +62 to +68
.nav__link:hover {
color: var(--main-color);
}

a.is-active {
color: var(--main-color);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.nav__link:hover {
color: var(--main-color);
}
a.is-active {
color: var(--main-color);
}
.nav__link:hover,
a.is-active {
color: var(--main-color);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants