add solution #5348
Open
add solution #5348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izotovav
commented
Sep 9, 2024
izotovav
commented
- DEMO LINK
- TEST REPORT LINK
volodymyr-soltys97
suggested changes
Sep 9, 2024
src/index.html
Outdated
| <h1>Moyo header</h1> | ||
| <header class="header"> | ||
| <a | ||
| class="logo" |
There was a problem hiding this comment.
Suggested change
| class="logo" | |
| class="header__link" |
src/index.html
Outdated
Comment on lines
82
to
85
| <main> | ||
| <div class="div"></div> | ||
| </main> | ||
| <footer></footer> |
There was a problem hiding this comment.
Redundant
Suggested change
| <main> | |
| <div class="div"></div> | |
| </main> | |
| <footer></footer> |
Comment on lines
+6
to
+8
| font-family: Roboto, sans-serif; | ||
| font-size: 12px; | ||
| font-weight: 500; |
There was a problem hiding this comment.
Move font styles to the html selector
src/style.css
Outdated
Comment on lines
78
to
81
| div:hover::after { | ||
| outline: solid 1px; | ||
| text-decoration-color: var(--active-color); | ||
| } |
There was a problem hiding this comment.
Suggested change
| div:hover::after { | |
| outline: solid 1px; | |
| text-decoration-color: var(--active-color); | |
| } |
src/style.css
Outdated
| display: block; | ||
| height: 4px; | ||
| width: 37px; | ||
| background-color: #00acdc; |
There was a problem hiding this comment.
Create a variable for repeated colors
src/style.css
Outdated
| content: ''; | ||
| display: block; | ||
| height: 4px; | ||
| width: 37px; |
There was a problem hiding this comment.
Suggested change
| width: 37px; | |
| width: 100%; |
src/style.css
Outdated
| } | ||
|
|
||
| .logo { | ||
| position: absolut; |
There was a problem hiding this comment.
Suggested change
| position: absolut; |
src/style.css
Outdated
| color: var(--active-color); | ||
| } | ||
|
|
||
| .data-qa:hover { |
There was a problem hiding this comment.
Suggested change
| .data-qa:hover { | |
| .nav__link:hover { |
volodymyr-soltys97
suggested changes
Sep 10, 2024
src/index.html
Outdated
| <nav class="nav"> | ||
| <ul class="nav__list"> | ||
| <li class="nav__item"> | ||
| <a class="nav__link color is-active">Apple</a> |
There was a problem hiding this comment.
Suggested change
| <a class="nav__link color is-active">Apple</a> | |
| <a class="nav__link is-active">Apple</a> |
src/style.css
Outdated
| @@ -1,3 +1,80 @@ | |||
| body { | |||
| margin: 0; | |||
|
|
|||
| --active-color: #00acdc; | |||
There was a problem hiding this comment.
Create a variable with root selector
src/style.css
Outdated
Comment on lines
78
to
80
| .header:hover { | ||
| outline: solid 3px var(--active-color); | ||
| } |
There was a problem hiding this comment.
Suggested change
| .header:hover { | |
| outline: solid 3px var(--active-color); | |
| } |
src/style.css
Outdated
| color: var(--active-color); | ||
| } | ||
|
|
||
| a:hover { |
volodymyr-soltys97
approved these changes
Sep 11, 2024
src/index.html
Outdated
Comment on lines
41
to
42
| </a> | ||
| <nav class="nav"> |
There was a problem hiding this comment.
Suggested change
| </a> | |
| <nav class="nav"> | |
| </a> | |
| <nav class="nav"> |
src/index.html
Outdated
Comment on lines
50
to
51
| </li> | ||
| <li class="nav__item"> |
There was a problem hiding this comment.
Suggested change
| </li> | |
| <li class="nav__item"> | |
| </li> | |
| <li class="nav__item"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.