Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task done #5016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task done #5016

wants to merge 1 commit into from

Conversation

Yevhenia-S
Copy link

Checklist

  • there 2 BEM blocks card and stars each in their own file
  • SCSS Nesting is used for elements, modifiers and pseudo-classes
  • SCSS Variables are used for main values and placed in a separate file
  • all stars--N modifiers work as expected (Highlight first N stars)
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on organizing your code and following semantic HTML practices! 🎉 While there are a couple of minor issues, such as the need to compile your .scss files to .css and ensuring that all mixins are correctly imported, these do not critically impact the functionality of your project. Keep up the good work, and consider addressing these points to further improve your code quality. Happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines 25 to 27
<link
rel="stylesheet"
href="./styles/index.scss"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet link uses a .scss file extension, which is not directly supported by browsers. Ensure that the SASS file is compiled to a CSS file and link the resulting CSS file instead.

border-radius: 5px;
font-family: Roboto, serif;

@include content-padding-in-line;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mixin content-padding-in-line is used here, but it is not defined within this file. Ensure that this mixin is defined elsewhere and is correctly imported into this file to avoid compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants