Develop #5017
Develop #5017
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. These include separating the SCSS files for the card and stars BEM blocks, introducing SCSS variables in a separate file, and correcting several typos in class names that affect functionality. Additionally, ensure the image path and alt text are accurate. Once these changes are made, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
| class="card__photo" | ||
| /> | ||
|
|
||
| <h3 class="card__tittle"> |
There was a problem hiding this comment.
There is a typo in the class name 'card__tittle'. It should be 'card__title'.
| 5K Monoblock (MNED2UA/A) | ||
| </h3> | ||
|
|
||
| <p class="card__prodact-code">Product code: 195434</p> |
There was a problem hiding this comment.
There is a typo in the class name 'card__prodact-code'. It should be 'card__product-code'.
| > | ||
| <img | ||
| src="images/imac.jpeg" | ||
| alt="macbook" |
There was a problem hiding this comment.
The alt attribute for the image is 'macbook', but the image source is 'imac.jpeg'. Consider updating the alt text to accurately describe the image, such as 'iMac'.
| margin: 0 auto 40px; | ||
| } | ||
|
|
||
| &__tittle { |
There was a problem hiding this comment.
There is a typo in the class name '&__tittle'. It should be '&__title' to match the corrected HTML class name.
| font-weight: 500; | ||
| } | ||
|
|
||
| &__prodact-code { |
There was a problem hiding this comment.
There is a typo in the class name '&__prodact-code'. It should be '&__product-code' to match the corrected HTML class name.
| box-sizing: border-box; | ||
|
|
||
| &__photo { | ||
| background-image: url(..//images/imac.jpeg); |
There was a problem hiding this comment.
The URL for the background image contains a double slash ('..//'). It should be corrected to '../images/imac.jpeg'.
-DEMO LINK
[x] there 2 BEM blocks card and stars each in it own file
[x] SCSS Nesting is used for elements, modifiers and pseudo-classes
[x] SCSS Variables are used for main values and placed in a separate file
[x] all stars--N modifiers work as expected (Highlight first N stars)
[x] Code follows all the [Code Style Rules ]