add task solution #5024
add task solution #5024
Conversation
There was a problem hiding this comment.
Great job on your work! 🎉 You've met most of the task requirements, and the functionality is intact. There are a few minor issues, like the SCSS variables needing a separate file and some corrections in border styles and image paths. These don't impact the core functionality, so I'm approving your PR. Keep up the great work, and consider these improvements for future projects! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| > | ||
| <img | ||
| class="card__img" | ||
| src="././images/imac.jpeg" |
There was a problem hiding this comment.
The image source path '././images/imac.jpeg' seems to have an unnecessary './' at the beginning. It should be './images/imac.jpeg' instead.
| background: #00acdc; | ||
| width: 166px; | ||
| height: 40px; | ||
| border-style: 1px Solid #00acdc; |
There was a problem hiding this comment.
The border style declaration 'border-style: 1px Solid #00acdc;' is incorrect. It should be 'border: 1px solid #00acdc;' to properly define the border width, style, and color.
| background-repeat: no-repeat; | ||
| width: 16px; | ||
| height: 16px; | ||
| border-radius: 0.5px 0 0; |
There was a problem hiding this comment.
The border-radius property 'border-radius: 0.5px 0 0;' seems incorrect. Typically, border-radius is defined with four values (top-left, top-right, bottom-right, bottom-left) or one value for all corners. Please verify if this is intentional or if it should be corrected.
| background: #00acdc; | ||
| width: 166px; | ||
| height: 40px; | ||
| border-style: 1px Solid #00acdc; |
There was a problem hiding this comment.
The border style declaration 'border-style: 1px Solid #00acdc;' is incorrect. It should be 'border: 1px solid #00acdc;' to properly define the border width, style, and color.
| background-repeat: no-repeat; | ||
| width: 16px; | ||
| height: 16px; | ||
| border-radius: 0.5px 0 0; |
There was a problem hiding this comment.
The border-radius property 'border-radius: 0.5px 0 0;' seems incorrect. Typically, border-radius is defined with four values (top-left, top-right, bottom-right, bottom-left) or one value for all corners. Please verify if this is intentional or if it should be corrected.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
cardandstarseach in their own fileSCSS Nesting is used for
elements,modifiersandpseudo-classesSCSS Variables are used for main values and placed in a separate file
all
stars--Nmodifiers work as expected (Highlight firstNstars)Code follows all the Code Style Rules ❗️