My cards #5025
My cards #5025
Conversation
TaniaP26
commented
Nov 30, 2024
TaniaP26
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Great job on your submission! 🎉 Your code meets most of the task requirements and constraints, and you've done well with the HTML structure and SCSS organization. There are just a couple of minor improvements to consider: adjusting the opacity value to be between 0 and 1, and using a comma as the thousands separator in the price format for consistency. Keep up the good work and continue refining your skills! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| <div class="card__price"> | ||
| <div class="card__price--how">Price</div> | ||
| <div class="card__price--what">$2.199</div> |
There was a problem hiding this comment.
The price format uses a period as a thousands separator, which is unconventional in English-speaking countries where a comma is typically used. Consider changing '$2.199' to '$2,199' for consistency with common formatting standards.
| height: 40px; | ||
| margin: auto; | ||
| border-radius: 5px; | ||
| opacity: 0px; |
There was a problem hiding this comment.
The 'opacity' property is set to '0px', which is not a valid value. Opacity should be a number between 0 and 1, without units. Consider changing 'opacity: 0px;' to 'opacity: 0;'.
