-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #5026
base: master
Are you sure you want to change the base?
Develop #5026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the SCSS variables $main-text-color
and $secondary-text-color
are used but not defined, which could lead to compilation errors. Additionally, the stylesheet link is pointing to a SCSS file, which browsers cannot interpret directly. Please compile your SCSS into a CSS file and update the link accordingly. Once these issues are resolved, your code will be in great shape! Keep up the great work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
src/index.html
Outdated
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" | ||
href="./styles/style.scss" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stylesheet link is pointing to a SCSS file (style.scss
). Browsers cannot directly interpret SCSS files; they need to be compiled into CSS first. Ensure that you compile your SCSS into a CSS file and link to the resulting CSS file instead.
} | ||
|
||
&__title { | ||
color: $main-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-text-color
is used here, but it's not defined in this file. Ensure that this variable is defined in a parent file or imported correctly to avoid compilation errors.
@@ -0,0 +1,12 @@ | |||
html { | |||
color: $secondary-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $secondary-text-color
is used here, but it's not defined in this file. Ensure that this variable is defined in a parent file or imported correctly to avoid compilation errors.
font-size: 16px; | ||
font-weight: 700; | ||
line-height: 18px; | ||
color: $main-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-text-color
is used here, but it's not defined in this file. Ensure that this variable is defined in a parent file or imported correctly to avoid compilation errors.
justify-content: space-between; | ||
|
||
&__count { | ||
color: $main-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-text-color
is used here, but it's not defined in this file. Ensure that this variable is defined in a parent file or imported correctly to avoid compilation errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on addressing the previous issues with the SCSS variables and stylesheet link! 🎉 Your code now meets the task requirements and constraints, and there are no missing or unrelated files. However, there are a few critical issues that need attention:
-
SCSS Variables: Ensure that the
$main-text-color
and$secondary-text-color
variables are defined or imported in all relevant SCSS files to avoid compilation errors. -
Stylesheet Compilation: Make sure the SCSS file is compiled into the CSS file to ensure styles are applied correctly.
These issues are important for the functionality of your code, so please review the comments and make improvements. This decision is made to help you move forward with your learning. Keep up the good work and continue to learn from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<link | ||
rel="stylesheet" | ||
href="./styles/index.scss" | ||
href="./styles/style.css" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the SCSS file has been compiled into this CSS file. If the SCSS file is not compiled, the styles will not be applied correctly.
} | ||
|
||
&__title { | ||
color: $main-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-text-color
is used but not defined in this file. Ensure that it is defined or imported from another SCSS file to avoid compilation errors.
@@ -0,0 +1,12 @@ | |||
html { | |||
color: $secondary-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $secondary-text-color
is used but not defined in this file. Ensure that it is defined or imported from another SCSS file to avoid compilation errors.
font-size: 16px; | ||
font-weight: 700; | ||
line-height: 18px; | ||
color: $main-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-text-color
is used but not defined in this file. Ensure that it is defined or imported from another SCSS file to avoid compilation errors.
justify-content: space-between; | ||
|
||
&__count { | ||
color: $main-text-color; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable $main-text-color
is used but not defined in this file. Ensure that it is defined or imported from another SCSS file to avoid compilation errors.
DEMO LINK
TEST REPORT LINK
there 2 BEM blocks
card
andstars
each in their own fileSCSS Nesting is used for
elements
,modifiers
andpseudo-classes
SCSS Variables are used for main values and placed in a separate file
all
stars--N
modifiers work as expected (Highlight firstN
stars)Code follows all the Code Style Rules ❗️