add task solution #3733
Open
add task solution #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Oct 23, 2023
src/style.css
Outdated
Comment on lines
29
to
57
| .stars--1 :first-child { | ||
| background-image: url(images/star-active.svg); | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--2 :nth-child(-n + 2) { | ||
| background-image: url(images/star-active.svg); | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--3 :nth-child(-n + 3) { | ||
| background-image: url(images/star-active.svg); | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--4 :nth-child(-n + 4) { | ||
| background-image: url(images/star-active.svg); | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| } | ||
|
|
||
| .stars--5 :nth-child(n) { | ||
| background-image: url(images/star-active.svg); | ||
| background-position: center; | ||
| background-repeat: no-repeat; | ||
| } |
src/style.css
Outdated
Comment on lines
31
to
32
| background-position: center; | ||
| background-repeat: no-repeat; |
There was a problem hiding this comment.
it's redundant 'cause you specified that in .stars__star
src/style.css
Outdated
Comment on lines
14
to
18
| .stars { | ||
| width: 96px; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .stars { | |
| width: 96px; | |
| display: flex; | |
| justify-content: space-between; | |
| } | |
| .stars { | |
| display: flex; | |
| } |
it's redundant 'cause you specified the width property in star styles
src/style.css
Outdated
Comment on lines
9
to
12
| .container { | ||
| display: flex; | ||
| flex-direction: column; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the test does not pass, what could be the problem?