add task solution #4938
add task solution #4938
Conversation
AsyaDev14
commented
Oct 15, 2024
AsyaDev14
commented
- [x]Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
- Each BEM block has its own separate file
- All Typical Mistakes from BEM lesson theory are checked.
- Code follows all the Code Style Rules ❗️
There was a problem hiding this comment.
You've done a great job overall, but there are some issues that need to be addressed. Please correct the usage of the * selector and use classes instead of tag names for styling. Also, consider using semantic HTML for better readability and SEO. Keep up the good work! 💪🙂
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Great job so far! However, there are a few improvements that need to be made before this can be approved. Please consider adding a fallback font-family in your CSS and avoid using the * selector due to its impact on performance. In your HTML, try to use more semantic tags and format your attributes correctly. Keep up the good work! 👍
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <li class="stars__star"></li> | ||
| <li class="stars__star"></li> | ||
| </ul> | ||
|
|
