-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4967
base: master
Are you sure you want to change the base?
add task solution #4967
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the pull request! 🎉 The issues noted are minor and mostly related to code style. Keep up the good work and consider these suggestions for future improvements.
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next
<div class="stars__star"></div> | ||
<div class="stars__star"></div> | ||
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next
@@ -1 +1,29 @@ | |||
/* add styles here */ | |||
body { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling, except for html
and body
. Consider using a class or ID for styling the body element.
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️