Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #4967

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #4967

wants to merge 1 commit into from

Conversation

Deineko13
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the pull request! 🎉 The issues noted are minor and mostly related to code style. Keep up the good work and consider these suggestions for future improvements.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next

opening tag.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next

opening tag.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next

opening tag.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next

opening tag.

<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be a blank line between parent and child elements. Please remove the empty line between the closing tag and the next

opening tag.

@@ -1 +1,29 @@
/* add styles here */
body {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling, except for html and body. Consider using a class or ID for styling the body element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants