Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop #4968

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

develop #4968

wants to merge 1 commit into from

Conversation

DavidKuznets
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on structuring the HTML file! 🎉 The issues noted are minor and mostly related to code style. Keep up the good work and consider the feedback for future improvements.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines 13 to 14
/>
</head>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line between the closing link tag and the closing head tag to separate multiline sibling blocks of HTML.

Comment on lines +22 to +23
</div>
<div class="stars stars--1">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between these div blocks to separate multiline sibling blocks of HTML.

Comment on lines +29 to +30
</div>
<div class="stars stars--2">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between these div blocks to separate multiline sibling blocks of HTML.

Comment on lines +36 to +37
</div>
<div class="stars stars--3">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between these div blocks to separate multiline sibling blocks of HTML.

Comment on lines +43 to +44
</div>
<div class="stars stars--4">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between these div blocks to separate multiline sibling blocks of HTML.

Comment on lines +50 to +51
</div>
<div class="stars stars--5">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between these div blocks to separate multiline sibling blocks of HTML.

margin-right: 0;
}

div.stars--1 > *:first-child {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using tag names for styling. Instead of using 'div.stars--1', consider using just '.stars--1'. This aligns with the checklist item: 'Don't use tag names for styling (except html and body)'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants