-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
develop #4968
base: master
Are you sure you want to change the base?
develop #4968
Conversation
DavidKuznets
commented
Oct 16, 2024
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on structuring the HTML file! 🎉 The issues noted are minor and mostly related to code style. Keep up the good work and consider the feedback for future improvements.
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
/> | ||
</head> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be an empty line between the closing link tag and the closing head tag to separate multiline sibling blocks of HTML.
</div> | ||
<div class="stars stars--1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between these div blocks to separate multiline sibling blocks of HTML.
</div> | ||
<div class="stars stars--2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between these div blocks to separate multiline sibling blocks of HTML.
</div> | ||
<div class="stars stars--3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between these div blocks to separate multiline sibling blocks of HTML.
</div> | ||
<div class="stars stars--4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between these div blocks to separate multiline sibling blocks of HTML.
</div> | ||
<div class="stars stars--5"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an empty line between these div blocks to separate multiline sibling blocks of HTML.
margin-right: 0; | ||
} | ||
|
||
div.stars--1 > *:first-child { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using 'div.stars--1', consider using just '.stars--1'. This aligns with the checklist item: 'Don't use tag names for styling (except html and body)'.