-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #4978
base: master
Are you sure you want to change the base?
add task solution #4978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on structuring the file correctly! While there are some minor style improvements suggested, they don't impact the functionality. Keep up the good work and consider the feedback for future enhancements! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
.stars--1 :first-child, | ||
.stars--2 :nth-child(-n + 2), | ||
.stars--3 :nth-child(-n + 3), | ||
.stars--4 :nth-child(-n + 4), | ||
.stars--5 :nth-child(-n + 5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid using tag names for styling. Instead of using ':first-child' and ':nth-child', consider using class selectors to target specific elements. This will improve performance and maintainability.
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the blank line between the closing tag and the next
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the blank line between the closing tag and the next
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the blank line between the closing tag and the next
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the blank line between the closing tag and the next
</div> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be a blank line between parent and child elements. Please remove the blank line between the closing tag and the next
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical Mistakes
fromBEM
lesson theory are checked.Code follows all the Code Style Rules ❗️