layout_stars #4986
layout_stars #4986
Conversation
IOherhi
commented
Oct 25, 2024
IOherhi
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
It looks like there are a couple of critical issues that need to be addressed before we can approve this Pull Request. The extra class hui in the HTML violates the task requirement of not adding additional classes, and the necessary images are missing from the project, which affects the core functionality. Please make these adjustments, and you'll be all set! 😊 Keep up the great work!
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star"></div> | ||
| <div class="stars__star hui"></div> |
There was a problem hiding this comment.
There is an additional class 'hui' on this star element. Ensure that this is intentional and necessary for your design or functionality. If not, consider removing it to maintain consistency with other star elements.
| .stars--3 .stars__star:nth-last-child(n + 3), | ||
| .stars--4 .stars__star:nth-last-child(n + 2), | ||
| .stars--5 .stars__star:nth-last-child(n + 1) { | ||
| background-image: url(./images/star-active.svg); |
There was a problem hiding this comment.
Ensure that the image paths './images/star.svg' and './images/star-active.svg' are correct and that the images exist in the specified directory. This is crucial for the stars to display correctly.
