Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tast solition #5010

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AnhelinaSh2001
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your solution meets many of the task requirements, there are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the use of the universal selector in CSS can impact performance, and the file structure does not adhere to the requirement for each BEM block to have its own file. These issues are important for maintaining code quality and scalability. Please make these adjustments, and feel free to reach out if you need any help. Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the star rating system! 🌟 Your code meets most of the task requirements and constraints, which is a solid step forward. However, there are a few areas to improve:

  1. Reset Browser's Default Margin: Avoid using the universal selector (*) for resetting margins and paddings. Target specific elements instead.

  2. Use of Tag Names for Styling: It's best to avoid styling with tag names like div and span. Use classes for styling to maintain better control and scalability.

  3. Yellow Stars with Container Modifier + Pseudo-selector: Ensure that yellow stars are added using a container modifier and a pseudo-selector without extra classes, as per the task requirements.

  4. Each BEM Block in a Separate File: Consider separating each BEM block into its own file for better organization and maintainability.

Despite these issues, your implementation is on the right track. The decision to approve is to help you move forward with your learning journey. Please review the comments and address these points to enhance your code quality. Keep up the good work and continue to learn from these experiences! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants