Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #5011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Oleksandr-Piechieniev
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Hello! 😊 You've done a great job with the implementation, and your code is almost there! However, there's a critical issue with the CSS that needs to be addressed before we can approve the pull request:

  • CSS Selector Issue: The use of nth-child(-n) in the .stars--0 .stars__star:nth-child(-n) selector is incorrect and doesn't select any elements. This could lead to unexpected behavior in your star rating system. Please revise this selector to ensure it functions as intended, or consider removing it if it's not necessary.

Once you've made these changes, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you have any questions or need further assistance. 🌟

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/style.css Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants