Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #5021

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add task solution #5021

wants to merge 1 commit into from

Conversation

SoraEmpty
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 2, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 The structure and styling are well done, and you've adhered to most of the task requirements. The only minor issue is the unnecessary flex-direction property in the CSS, which doesn't affect functionality but could be cleaned up for clarity. Keep up the good work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

src/style.css
Comment on lines +9 to +10
.stars__star {
flex-direction: column;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flex-direction: column; property is unnecessary here because .stars__star is set to display: block;, which does not support flex properties. Consider removing this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoraEmpty @mateacademy-ai-mentor