Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ross is still Rachel's husband, and Rachel is Ross's wife. #1628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ross is still Rachel's husband, and Rachel is Ross's wife. #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions app/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,25 @@
class Person:
# write your code here
pass
people = {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The people dictionary is a class variable, which means it will be shared across all instances of the Person class. This might lead to unexpected behavior if you intend to have separate lists of people for different contexts. Consider whether this is the intended design.


def __init__(self, name: str, age: int):
self.name = name
self.age = age
Person.people[name] = self


def create_person_list(people: list) -> list:
# write your code here
pass
person_instances = []

for person_data in people:
name = person_data["name"]
age = person_data["age"]
person_instances.append(Person(name, age))

for person_data in people:
name = person_data["name"]
if "wife" in person_data and person_data["wife"] is not None:
Person.people[name].wife = Person.people[person_data["wife"]]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code assumes that the 'wife' key in person_data corresponds to a name that already exists in Person.people. If the name does not exist, this will raise a KeyError. Consider adding error handling to manage cases where the referenced person does not exist.

if "husband" in person_data and person_data["husband"] is not None:
Person.people[name].husband = Person.people[person_data["husband"]]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the handling of 'wife', the code assumes that the 'husband' key in person_data corresponds to a name that already exists in Person.people. This can also raise a KeyError if the name does not exist. Consider adding error handling for this case as well.


return list(Person.people.values())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning list(Person.people.values()) will return all Person instances ever created, due to the use of a class variable. If you only want to return the instances created in this function call, consider using a local variable to store the instances.

Loading