Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings about missing field initializer #102

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

rbuj
Copy link
Contributor

@rbuj rbuj commented Oct 28, 2021

test_metar.c:24:9: warning: missing field 'short_name' initializer [-Wmissing-field-initializers]
        { NULL }
               ^
--
test_sun_moon.c:30:9: warning: missing field 'short_name' initializer [-Wmissing-field-initializers]
        { NULL }
               ^

Copy link
Member

@mbkma mbkma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds fine

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These build with no warnings w my default build options. The two test files changed test_metar and test_sun_moon seem to work fine, though I don't really know how to test them right. test_sun_moon definately gave a chart of valid looking results when fed a valid latitude and longitude however

@lukefromdc lukefromdc merged commit ff251d6 into master Dec 13, 2022
@lukefromdc lukefromdc deleted the missing-field-initializers branch December 13, 2022 04:10
@lukefromdc
Copy link
Member

We really should get a 1.27.0 release of this out BTW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants