-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename Europe/Kiev to Europe/Kyiv #115
Conversation
This is long overdue given the war
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found two more places this needs to change in order to show "Kyiv" when adding this city beginning at line 20707:
<!-- The capital of Ukraine.
"Kiev" is the traditional English name.
The local name in Ukrainian is "Kyyiv".
-->
<name>Kiev</name>
<coordinates>50.433333 30.516667</coordinates>
changes to
<!-- The capital of Ukraine.
"kyiv" is the traditional English name.
The local name in Ukrainian is "Kyyiv".
-->
<name>kyiv</name>
<coordinates>50.433333 30.516667</coordinates>
Then it works. Install, restart mate-panel and add Kyiv to start
"kyiv" is the traditional RUSSIAN name for this city...
After this PR is merged, I will release 1.27 of libmateweather and then all repos (finally) are at 1.27. |
Anyone else likes to review? |
To throw a shade on the linguistic rationale, English spelling for toponyms does not have to reflect the modern spellings in local languages, and it almost never does (Vienna is not Wein, Rome is not Roma, Moscow is not Moskva, Prague is not Praha). On top of that "Kiev" is not intrinsically Russian as the historic East Slavic name of the city is "Kyyevŭ", or, simplified, "Kyev". However I couldn't verify at what point the loan to English occured, so maybe it was actually from Russian. The Latin spelling is "Kyov" (presumably from Polish), so that's not the origin for the English spelling. But although the word-origins argument is not as strong as some people think the shift gains traction and it's not our place to be prudes about it: upstream (eggert/tz@e13e9c5) renamed |
Moreover, this PR fixes the build which was failing before, see https://app.travis-ci.com/github/mate-desktop/libmateweather/jobs/591004675#L2038. With my system (Debian 11) the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retested with the latest changes, works great now, will merge
No description provided.