Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename Europe/Kiev to Europe/Kyiv #115

Merged
merged 1 commit into from
Jan 13, 2023
Merged

rename Europe/Kiev to Europe/Kyiv #115

merged 1 commit into from
Jan 13, 2023

Conversation

mbkma
Copy link
Member

@mbkma mbkma commented Jan 11, 2023

No description provided.

@lukefromdc
Copy link
Member

lukefromdc commented Jan 12, 2023 via email

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found two more places this needs to change in order to show "Kyiv" when adding this city beginning at line 20707:

        <!-- The capital of Ukraine.
             "Kiev" is the traditional English name.
             The local name in Ukrainian is "Kyyiv".
          -->
        <name>Kiev</name>
        <coordinates>50.433333 30.516667</coordinates>

changes to

        <!-- The capital of Ukraine.
             "kyiv" is the traditional English name.
             The local name in Ukrainian is "Kyyiv".
          -->
        <name>kyiv</name>
        <coordinates>50.433333 30.516667</coordinates>

Then it works. Install, restart mate-panel and add Kyiv to start
"kyiv" is the traditional RUSSIAN name for this city...

@lukefromdc lukefromdc requested a review from a team January 12, 2023 03:53
@mbkma
Copy link
Member Author

mbkma commented Jan 12, 2023

After this PR is merged, I will release 1.27 of libmateweather and then all repos (finally) are at 1.27.

@mbkma
Copy link
Member Author

mbkma commented Jan 13, 2023

Anyone else likes to review?

@XRevan86
Copy link

To throw a shade on the linguistic rationale, English spelling for toponyms does not have to reflect the modern spellings in local languages, and it almost never does (Vienna is not Wein, Rome is not Roma, Moscow is not Moskva, Prague is not Praha). On top of that "Kiev" is not intrinsically Russian as the historic East Slavic name of the city is "Kyyevŭ", or, simplified, "Kyev". However I couldn't verify at what point the loan to English occured, so maybe it was actually from Russian. The Latin spelling is "Kyov" (presumably from Polish), so that's not the origin for the English spelling.
One could argue that because it's "Kiev" and not "Kyev", it does contain a modern Russian-specific sound change, but that's assuming exact transliteration – unlike Slavic languages English is very willy-nilly about i/y (i.e. obsolete yland for island).

But although the word-origins argument is not as strong as some people think the shift gains traction and it's not our place to be prudes about it: upstream (eggert/tz@e13e9c5) renamed Europe/Kiev to Europe/Kyiv and it only makes sense to follow suit.

@mbkma
Copy link
Member Author

mbkma commented Jan 13, 2023

Moreover, this PR fixes the build which was failing before, see https://app.travis-ci.com/github/mate-desktop/libmateweather/jobs/591004675#L2038. With my system (Debian 11) the file /usr/share/zoneinfo/zone.tab also lists Europe/Kyiv which is the origin of the build failure.

Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retested with the latest changes, works great now, will merge

@lukefromdc lukefromdc merged commit 7b60a32 into master Jan 13, 2023
@lukefromdc lukefromdc deleted the fix-build branch January 13, 2023 20:05
raveit65 pushed a commit that referenced this pull request Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants