-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time-admin dependency check on systemd #748
Conversation
@cwendling I am not very familiar with autoconf, can I modify it this way? |
Looks to me like we are setting a variable, then setting it to a non-null value only if systemd is detected. I also don't know the build systems that well but this should have the same effect when systemd is not present as the We also support meson for mate-control-center, though only one actually HAS to work for non-systemd distros to build m-c-c today, the point to any meson work is an eventual transition to it. That is important especially if autotools ever goes unmaintained. |
After this PR is accepted, I will add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost OK :)
You can also verify it does the right thing if make dist
creates a tarball with the time-admin capplet sources when run from a build tree configured with systemd disabled.
time-admin depends on systemd. If systemd is not used in the systemd, time-admin is disabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #744 |
time-admin depends on systemd. If systemd is not used in the systemd, time-admin is disabled