Added an extension for opening a symlink's parent directory

[CreamyCookie]

License: CC0 (https://creativecommons.org/publicdomain/zero/1.0/)

[raveit65]

Anyone around with python experience to review this PR?

[vkareh]

@raveit65 - I tried testing this but wasn't able to get any of the example plugins to load... I'll give it another try later this week, but it might be something in my caja build configuration that I'll have to check.

[CreamyCookie]

Okay, I just realized that there's no reason to not make it work with directory symlinks, so it now does.

[CreamyCookie]

Sorry for all the additional commits. I think it's finished now.

Should I create new pull request that only contains the main commit (but with the fixes etc. merged)?

[vkareh]

@CreamyCookie - you can just squash your commits instead into a single one (or we can do it during merge - github has a button for squashing on my view)

[raveit65]

@vkareh
If you choose squash on github site than you generate a merge commit.
Better do that local with git rebase -i last-good-commit-id
i= interactive

[CreamyCookie]

Interesting, didn't know GitHub had that feature.

@raveit65 Maybe I'm misunderstanding, but the docs seem to suggest that it does get squashed to a single commit, i.e. no additional merge commit:

https://help.github.com/articles/about-pull-request-merges/#squash-and-merge-your-pull-request-commits

[raveit65]

Try it out in a own test repo, it produce garbage.

[CreamyCookie]

@raveit65 Huh? Worked perfectly fine on my end: https://github.com/CreamyCookie/test (squashed and merged the feature branch which contains the 3 new commits)

[vkareh]

@raveit65 - do you know how to build this so that the example plugins load in caja? They just don't show up for me...

[CreamyCookie]

@vkareh For me it works, just putting them in ~/.local/share/caja-python/extensions and then killing and restarting caja.

[raveit65]

@vkareh
I don't know , i used the package only for caja-terminal (embeded terminal) for a while.
But since i dropped this package for fedora i don't use caja-python any more.
Currently i am thinking about to drop python-caja for fedora too, to reduce my workload.

[monsta]

"Squash and merge" button here should not generate an additional merge commit... it will only place PR number into first line of commit message - but you can delete that part manually before merging.

Besides the mentioned local folder, Python extensions can be placed into /usr/share/caja-python/extensions/.

[monsta]

It works, just need to add this new file to examples/Makefile.am, otherwise it's not installed

[raveit65]

Is this python-3.6 compatible?

[CreamyCookie]

@raveit65 If you mean this extension, then yes AFAICS.

[raveit65]

python-caja can easily build with python-3.6, see this PR for fedora downstream package
https://src.fedoraproject.org/rpms/python-caja/pull-request/2
It would be hurt to break this.

[CreamyCookie]

When I was looking at the code regarding Python 3.6 compatibility (to be sure), I've noticed another potential bug. This line wouldn't work with paths that contain double quotes:

os.system('caja "%s" &' % parent)

So, it's now using the subprocess module which is recommended anyway and also handles escaping. Oh, and instead of calling caja for each path, I now call it once with all the paths.

[monsta]

Hmm, I didn't notice it before, but there's a runtime warning in ~/.xsession-errors:

RuntimeError: object at 0x7fa52623b140 of type OpenSymLinksParentDirsExtension is not initialized

[CreamyCookie]

Interesting, I'm also getting that for the plugins included in Ubuntu MATE:

RuntimeError: object at 0x7f722686d8c0 of type OpenSymLinksParentDirsExtension is not initialized
RuntimeError: object at 0x7f722686d5f0 of type FolderColorMenu is not initialized
RuntimeError: object at 0x7f722686d5a0 of type RenameMenu is not initialized

Hmm.. could this be a result of my empty __init__?

Oh completely missed this comment of yours:

It works, just need to add this new file to examples/Makefile.am, otherwise it's not installed

Should I add my file to examples/Makefile.am ? Anything else that is blocking this? (Besides maybe the above xsession-errors)

[raveit65]

Any news on this.
@mate-desktop/core-team
Can someone answered last questions from author, please?