Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update testdouble to the latest version #1114

Merged
merged 4 commits into from
Aug 11, 2017
Merged

Conversation

lynnmercier
Copy link
Contributor

This is the same as #1058, but I made it the ^ version. I think we can rely on all minor updates to testdouble.

I will also close #849 in favor of this PR

@codecov-io
Copy link

codecov-io commented Aug 11, 2017

Codecov Report

Merging #1114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          68       68           
  Lines        3296     3296           
  Branches      405      405           
=======================================
  Hits         3294     3294           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b8bbe...ab35c8c. Read the comment docs.

@acdvorak acdvorak self-assigned this Aug 11, 2017
Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include a package-lock.json update? It seems to update for me when I npm i with this change.

Also, it would appear that 3.2.4 is now the latest version :)

@lynnmercier lynnmercier merged commit 05e83e9 into master Aug 11, 2017
@lynnmercier lynnmercier deleted the chore/testdouble branch August 17, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants