fix(infrastructure): Harden closure declaration source rewriting #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bogusred |
- Ensure that all JS src files are recursively picked up when sending `--js` flag to closure compiler - Ensure `export ... from ...` statements are covered when rewriting declaration sources.
traviskaufman
force-pushed
the
fix/harden-closure-src-rewriting
branch
from
f5c974c to
8a2baf1
Compare
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 68 68
Lines 3144 3144
Branches 387 387
=======================================
Hits 3142 3142
Misses 2 2Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--jsflag to closure compilerexport ... from ...statements are covered when rewritingdeclaration sources.