fix(menu): incorrect elevation

PiperOrigin-RevId: 517485685
material-components · Mar 17, 2023 · 427d33d · 427d33d
1 parent 618a505
commit 427d33d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/menu/lib/_menu.scss b/menu/lib/_menu.scss
@@ -112,7 +112,7 @@ $_custom-property-prefix: 'menu';
 
 @function _resolve-tokens($tokens) {
   $menu-tokens: _remove-unused-tokens($tokens);
-  @return elevation.resolve-tokens($menu-tokens, 'elevation-key');
+  @return elevation.resolve-tokens($menu-tokens, 'container-elevation');
 }
 
 // removes unused tokens

diff --git a/menu/lib/menu.ts b/menu/lib/menu.ts
@@ -240,11 +240,13 @@ export abstract class Menu extends LitElement {
    * Renders the positionable surface element and its contents.
    */
   protected renderSurface() {
+    // TODO(b/274140618): elevation should be an underlay, not an overlay that
+    // tints content
     return html`
        <div
            class="menu ${classMap(this.getSurfaceClasses())}"
            style=${styleMap(this.menuPositionController.surfaceStyles)}>
-        ${this.renderList()} 
+        ${this.renderList()}
         ${this.renderElevation()}
         ${this.renderFocusRing()}
        </div>