Skip to content

Commit

Permalink
chore: fix closure compiler issues
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 564867173
  • Loading branch information
material-web-copybara authored and copybara-github committed Sep 12, 2023
1 parent 78e7c17 commit 556e6f9
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion checkbox/internal/checkbox.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export class Checkbox extends LitElement {
this.internals.setValidity({customError: !!error}, error, this.getInput());
}

protected override update(changed: PropertyValues<this>) {
protected override update(changed: PropertyValues<Checkbox>) {
if (changed.has('checked') || changed.has('disabled') ||
changed.has('indeterminate')) {
this.prevChecked = changed.get('checked') ?? this.checked;
Expand Down
2 changes: 1 addition & 1 deletion chips/internal/chip-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class ChipSet extends LitElement {
}
}

protected override updated(changed: PropertyValues<this>) {
protected override updated(changed: PropertyValues<ChipSet>) {
if (changed.has('singleSelect') && this.singleSelect) {
let hasSelectedChip = false;
for (const chip of this.chips as MaybeSelectableChip[]) {
Expand Down
2 changes: 1 addition & 1 deletion chips/internal/filter-chip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export class FilterChip extends MultiActionChip {
@query('.trailing.action')
protected readonly trailingAction!: HTMLElement|null;

protected override updated(changed: PropertyValues<this>) {
protected override updated(changed: PropertyValues<FilterChip>) {
if (changed.has('selected') && changed.get('selected') !== undefined) {
// Dispatch when `selected` changes, except for the first update.
this.dispatchEvent(new Event('selected', {bubbles: true}));
Expand Down
2 changes: 1 addition & 1 deletion focus/internal/focus-ring.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class FocusRing extends LitElement implements Attachable {
}
}

override update(changed: PropertyValues<this>) {
override update(changed: PropertyValues<FocusRing>) {
if (changed.has('visible')) {
// This logic can be removed once the `:has` selector has been introduced
// to Firefox. This is necessary to allow correct submenu styles.
Expand Down
4 changes: 2 additions & 2 deletions list/internal/listitem/list-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export class ListItemEl extends LitElement implements ListItem {

protected isFirstUpdate = true;

protected override willUpdate(changed: PropertyValues<this>) {
protected override willUpdate(changed: PropertyValues<ListItemEl>) {
if (changed.has('active') && !this.disabled) {
if (this.active) {
this.itemTabIndex = 0;
Expand Down Expand Up @@ -268,7 +268,7 @@ export class ListItemEl extends LitElement implements ListItem {
protected onMouseenter?(event: Event): void;
protected onMouseleave?(event: Event): void;

protected override updated(changed: PropertyValues<this>) {
protected override updated(changed: PropertyValues<ListItemEl>) {
super.updated(changed);

// will focus the list item root if it is selected but not on the first
Expand Down
2 changes: 1 addition & 1 deletion menu/internal/submenuitem/sub-menu-item.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class SubMenuItem extends MenuItemEl {
></slot></span>`;
}

override firstUpdated(changed: PropertyValues<this>) {
override firstUpdated(changed: PropertyValues<SubMenuItem>) {
super.firstUpdated(changed);

const {handleEvent} = this.rippleEl;
Expand Down
2 changes: 1 addition & 1 deletion ripple/internal/ripple.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export class Ripple extends LitElement implements Attachable {
return html`<div class="surface ${classMap(classes)}"></div>`;
}

protected override update(changedProps: PropertyValues<this>) {
protected override update(changedProps: PropertyValues<Ripple>) {
if (changedProps.has('disabled') && this.disabled) {
this.hovered = false;
this.pressed = false;
Expand Down
4 changes: 2 additions & 2 deletions select/internal/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ export abstract class Select extends LitElement {
return hasSelectedOptionChanged;
}

protected override update(changed: PropertyValues<this>) {
protected override update(changed: PropertyValues<Select>) {
// In SSR the options will be ready to query, so try to figure out what
// the value and display text should be.
if (!this.hasUpdated) {
Expand All @@ -415,7 +415,7 @@ export abstract class Select extends LitElement {
super.update(changed);
}

protected override async firstUpdated(changed: PropertyValues<this>) {
protected override async firstUpdated(changed: PropertyValues<Select>) {
await this.menu?.updateComplete;
// If this has been handled on update already due to SSR, try again.
if (!this.lastSelectedOptionRecords.length) {
Expand Down
4 changes: 2 additions & 2 deletions select/internal/selectoption/select-option.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class SelectOptionEl extends MenuItemEl implements SelectOption {

override readonly type: ListItemRole = 'option';

override willUpdate(changed: PropertyValues<this>) {
override willUpdate(changed: PropertyValues<SelectOptionEl>) {
if (changed.has('selected')) {
// Synchronize selected -> active but not the other way around because
// active is used for keyboard navigation and doesn't mean the option
Expand All @@ -46,7 +46,7 @@ export class SelectOptionEl extends MenuItemEl implements SelectOption {
super.willUpdate(changed);
}

override updated(changed: PropertyValues<this>) {
override updated(changed: PropertyValues<SelectOptionEl>) {
super.updated(changed);
// Restore the active = true focusing behavior which happens in
// super.updated() if it was turned off.
Expand Down

0 comments on commit 556e6f9

Please sign in to comment.