Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Retrieve macOS accent color #42

Merged
merged 13 commits into from
May 25, 2022
Merged

Retrieve macOS accent color #42

merged 13 commits into from
May 25, 2022

Conversation

ebraminio
Copy link
Contributor

@ebraminio ebraminio commented May 24, 2022 •
edited
Loading

This introduces getControlAccentColor and implements it in macOS.

Fixes material-foundation/flutter-packages#338

Guess some API reimagination would be needed but at least it works I can say,

Screen Shot 2022-05-24 at 6 47 55 PM

@ebraminio ebraminio mentioned this pull request Feb 1, 2023
Closed
@ebraminio
Retrieve macOS accent color
d0168c2 
This introduces getControlAccentColor and implements it in macOS.
guidezpl
guidezpl suggested changes May 24, 2022
View reviewed changes
example/pubspec.lock Outdated Show resolved Hide resolved
lib/src/dynamic_color_builder.dart Outdated Show resolved Hide resolved
lib/src/dynamic_color_builder.dart Outdated Show resolved Hide resolved
lib/src/dynamic_color_builder.dart Outdated Show resolved Hide resolved
lib/src/dynamic_color_plugin.dart Show resolved Hide resolved
lib/src/dynamic_color_plugin.dart Outdated Show resolved Hide resolved
lib/src/dynamic_color_plugin.dart Outdated Show resolved Hide resolved
lib/src/dynamic_color_builder.dart Outdated Show resolved Hide resolved
@guidezpl
Copy link
Contributor

guidezpl commented May 24, 2022 •
edited
Loading

Thanks for the PR! We'll need to update the README.

ebraminio
ebraminio commented May 24, 2022
View reviewed changes
pubspec.yaml Show resolved Hide resolved
@ebraminio
Copy link
Contributor Author

Partially addressed some of the reviews hopefully, 14c65f5

@guidezpl
Copy link
Contributor

Looking close. You'll also want to create a small example and tests so that the functionality you're adding can't be broken in the future.

@ebraminio
Copy link
Contributor Author

ebraminio commented May 24, 2022 •
edited
Loading

You'll also want to create a small example and tests so that the functionality you're adding can't be broken in the future.

Done hopefully.

guidezpl
guidezpl approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

I made small updates for consistency, and bumped the version to 1.3.0.

@guidezpl guidezpl merged commit ee167fe into material-foundation:main May 25, 2022
@ebraminio ebraminio deleted the macos branch May 26, 2022 16:43
This was referenced Feb 1, 2023
Open
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrieve macOS accent colors
2 participants
@ebraminio @guidezpl