Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Feature Discovery animation no longer works in 2.1.0 #488

Closed
3 tasks done
OlivierMadant opened this issue Jun 24, 2024 · 3 comments · Fixed by #497
Closed
3 tasks done

[Bug]: Feature Discovery animation no longer works in 2.1.0 #488

OlivierMadant opened this issue Jun 24, 2024 · 3 comments · Fixed by #497
Labels
bug Something isn't working

Comments

@OlivierMadant
Copy link

OlivierMadant commented Jun 24, 2024

Before submitting...

Context

The Feature Discovery animation no longer works in 2.1.0

Current Behavior

The background of the component is white:
image

Steps to reproduce

1.Open the link : Feature Discovery animation no longer works in 2.1.0
2.Click on "Open tap target"

Your Environment

  • Version used: Release 2.1.0
@OlivierMadant OlivierMadant added the bug Something isn't working label Jun 24, 2024
@OlivierMadant
Copy link
Author

OlivierMadant commented Jun 30, 2024

After analysis, it appears to be a simple CSS issue, specifically the component's background color and text color.

I think we could change https://github.com/materializecss/materialize/blob/main/sass/components/_tapTarget.scss#L39 Line 39 by:
background-color: var(--md-sys-color-primary-container);
color: var(--md-sys-color-primary);

to use the same color as the btn-floating at the bottom right of the tap component.

@OlivierMadant
Copy link
Author

I can prepare a PR if the diagnosis and solution are correct

@OlivierMadant
Copy link
Author

I prepared a PR : #490
Could you please review?

@danice danice closed this as completed in 8685841 Jul 29, 2024
danice added a commit that referenced this issue Jul 29, 2024
 fix(tapTarget): restore Feature Discovery animation and fix #488
@wuda-io wuda-io mentioned this issue Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant