Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): 🔒 fix many security issues, #141

Merged
merged 1 commit into from
May 23, 2021
Merged

build(deps): 🔒 fix many security issues, #141

merged 1 commit into from
May 23, 2021
+673 −766

Conversation

ChildishGiant
Copy link
Member

This includes upgrading jade to pug

Proposed changes

Currently running npm audit on v1-dev shows 202 vulnerabilities (3 low, 16 moderate, 182 high, 1 critical). This can be partially fixed automatically but I've gone ahead and done it all.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf DanielRuf requested a review from a team May 11, 2021 17:33
@roiLeo
Copy link
Member

roiLeo commented May 21, 2021

Does it break the documentation? Can we see a live preview?

@ChildishGiant
Copy link
Member Author

ChildishGiant commented May 21, 2021 •
edited
Loading

I've run all changes locally with no issue, including tests. Here's a bodged host (just uploaded the output from a local build). No noticeable changes. https://childishgiant.github.io/test-host/index.html

@ChildishGiant ChildishGiant mentioned this pull request May 21, 2021
Merged
Smankusors
Smankusors approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@Smankusors Smankusors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielRuf DanielRuf merged commit a8e6b38 into materializecss:v1-dev May 23, 2021
@ChildishGiant ChildishGiant deleted the audit branch September 18, 2021 23:29
@Smankusors Smankusors added the meta Issues with the project itself or our GitHub repository. label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smankusors Smankusors Smankusors approved these changes

Assignees
No one assigned
Labels
meta Issues with the project itself or our GitHub repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChildishGiant @roiLeo @Smankusors @DanielRuf