Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open old docs in new window #155

Merged
merged 2 commits into from Jul 22, 2021
Merged

open old docs in new window #155

merged 2 commits into from Jul 22, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2021

Proposed changes

Hello! Haven't had time to contribute in a while. I noticed the docs for 0.100.2 include a link back to the v1 beta docs. Clicking on that took me to materializecss.com, and I thought that was confusing since the latest ones on Github look very similar. I thought the best way to mitigate this issue was to open the older docs in a new window.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DanielRuf
Copy link

Hi @christinavoudouris,

that is a great idea! And awesome to see that you have added the rel options to prevent tabnabbing attacks. Big 👍 from my side.

I have updated the markup in your comment so the checkboxes are correctly rendered.

@DanielRuf DanielRuf merged commit 3b32d4d into materializecss:v1-dev Jul 22, 2021
@DanielRuf
Copy link

Thank you very much for your contribution.

@ghost ghost deleted the doc-fix branch July 22, 2021 22:25
@Smankusors Smankusors added the documentation Improvements or additions to documentation label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants