Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrong href value on <a> tag #170

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

boileaum
Copy link

Add /materialize prefix to href value.

@Smankusors Smankusors linked an issue Aug 24, 2021 that may be closed by this pull request
@Smankusors
Copy link
Member

Hi, can you fix the commitlint error? I appreciate it if you can do that.

To do that, you can undo the commit, and then create a new commit with a correct message, and then do force push to your branch. I think 1 commit is also enough for this PR.

@DanielRuf
Copy link

There are still some commitlint problems. What commit message should succeed the lint tests @Smankusors?

@Smankusors
Copy link
Member

oh, sorry for the late reply. The commit message needs to follow this rule

[type]: [subject]

in this case, your commit message should be

fix: Remove leading '/' from href

I think we should document this commitlint in the CONTRIBUTING document 🤔

@DanielRuf
Copy link

DanielRuf commented Sep 14, 2021

I'm fixing the commit message locally, it seems is has to start lowercase.

@DanielRuf DanielRuf merged commit e8384f5 into materializecss:v1-dev Sep 14, 2021
@DanielRuf
Copy link

@boileaum thank you very much for your contribution. I have invited you to the materializecss org as member.

@Smankusors Smankusors changed the title Fix #169 Fix Wrong href value on <a> tag Apr 7, 2022
@Smankusors Smankusors added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong href value on <a> tag
3 participants